Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: ak._v2.is_none check for axis value #1539

Merged
merged 6 commits into from
Jul 8, 2022
Merged

Fix: ak._v2.is_none check for axis value #1539

merged 6 commits into from
Jul 8, 2022

Conversation

ioanaif
Copy link
Collaborator

@ioanaif ioanaif commented Jul 8, 2022 •
edited
Loading

@codecov
Copy link

codecov bot commented Jul 8, 2022 •
edited
Loading

Codecov Report

Merging #1539 (ea5ef38) into main (78a6535) will decrease coverage by 0.12%.
The diff coverage is 60.81%.

Impacted Files Coverage Δ
src/awkward/_v2/contents/indexedoptionarray.py 89.14% <54.54%> (-0.70%) ⬇️
src/awkward/_v2/highlevel.py 70.77% <57.60%> (-2.76%) ⬇️
src/awkward/_v2/_connect/numba/arrayview.py 96.76% <100.00%> (ø)
src/awkward/_v2/contents/content.py 76.61% <100.00%> (ø)
src/awkward/_v2/operations/ak_copy.py 100.00% <100.00%> (ø)
src/awkward/_v2/operations/ak_is_none.py 96.55% <100.00%> (+0.39%) ⬆️
src/awkward/_v2/record.py 76.86% <100.00%> (-0.18%) ⬇️
src/awkward/_v2/types/recordtype.py 86.72% <100.00%> (-0.35%) ⬇️
src/awkward/_v2/types/numpytype.py 88.09% <0.00%> (-1.20%) ⬇️
src/awkward/_v2/operations/ak_type.py 53.84% <0.00%> (+2.56%) ⬆️

@ioanaif ioanaif requested a review from jpivarski July 8, 2022 16:54
@jpivarski jpivarski linked an issue Jul 8, 2022 that may be closed by this pull request
ak._v2.is_none should reject axis values that are too large #1417
Closed
jpivarski
jpivarski approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! (I also tested the negative axis cases, and everything is as it should be.)

@jpivarski jpivarski merged commit 8c070be into main Jul 8, 2022
@jpivarski jpivarski deleted the ioanaif/fix-v2-is_none-1417 branch July 8, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ak._v2.is_none should reject axis values that are too large
2 participants
@ioanaif @jpivarski