Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: lint PR titles according to conventional commits #1615

Merged
merged 3 commits into from
Aug 22, 2022

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Aug 22, 2022

This PR introduces a new workflow that runs on PRs:
https://github.com/amannn/action-semantic-pull-request

By default, this uses the commitizen (angular derivative) convention:

Note that some/all of the commits in this PR use a sentence-cased variant, because that was what I was used to. The new standard is lowercase prefixes.

@agoose77
Copy link
Collaborator Author

Good, the checks fail for maint:. Now try ci:...

@agoose77 agoose77 changed the title maint: lint PR titles according to conventional commits ci: lint PR titles according to conventional commits Aug 22, 2022
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1615 (3907522) into main (9e17f29) will decrease coverage by 0.02%.
The diff coverage is 62.09%.

Impacted Files Coverage Δ
src/awkward/_v2/_connect/cuda/__init__.py 0.00% <0.00%> (ø)
src/awkward/_v2/_connect/numexpr.py 88.40% <0.00%> (ø)
src/awkward/_v2/_connect/pyarrow.py 88.46% <0.00%> (ø)
src/awkward/_v2/numba.py 93.47% <0.00%> (ø)
src/awkward/_v2/operations/ak_from_avro_file.py 66.66% <0.00%> (ø)
src/awkward/_v2/operations/ak_local_index.py 100.00% <ø> (ø)
src/awkward/_v2/operations/ak_type.py 53.84% <0.00%> (ø)
src/awkward/_v2/operations/ak_transform.py 8.62% <8.62%> (ø)
src/awkward/_v2/contents/unionarray.py 86.16% <50.00%> (-0.11%) ⬇️
src/awkward/_v2/contents/bitmaskedarray.py 71.53% <53.84%> (+5.11%) ⬆️
... and 26 more

@agoose77
Copy link
Collaborator Author

@henryiii @jpivarski you both expressed an interest in this (by engaging in the discussion on Zoom)! Let me know if you are happy to merge this as-is, or want any changes.

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this one is

Lint PR / Validate PR title (pull_request) Successful in 3s

(I was wondering what form the title test would take, since it's not a git-level thing.)

Works for me. I can make this a requirement. I'll merge this now and make it a requirement on Wednesday, since everyone with an open PR will have to merge this branch.

@jpivarski
Copy link
Member

Although I'll give @henryiii a chance to weigh in before actually merging.

Copy link
Member

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, we could always remove it if it doesn't work out well for us.

@jpivarski jpivarski merged commit cbb2412 into main Aug 22, 2022
@jpivarski jpivarski deleted the agoose77/chore-lint-pr-title branch August 22, 2022 14:42
jpivarski added a commit to scikit-hep/uproot5 that referenced this pull request Aug 24, 2022
jpivarski added a commit to scikit-hep/uproot5 that referenced this pull request Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants