-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: lint PR titles according to conventional commits #1615
Conversation
This will help us to automate release notes in future
Good, the checks fail for |
Codecov Report
|
@henryiii @jpivarski you both expressed an interest in this (by engaging in the discussion on Zoom)! Let me know if you are happy to merge this as-is, or want any changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this one is
Lint PR / Validate PR title (pull_request) Successful in 3s
(I was wondering what form the title test would take, since it's not a git-level thing.)
Works for me. I can make this a requirement. I'll merge this now and make it a requirement on Wednesday, since everyone with an open PR will have to merge this branch.
Although I'll give @henryiii a chance to weigh in before actually merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me, we could always remove it if it doesn't work out well for us.
This is a total [crib](https://idioms.thefreedictionary.com/crib+from) from scikit-hep/awkward#1615.
This PR introduces a new workflow that runs on PRs:
https://github.com/amannn/action-semantic-pull-request
By default, this uses the commitizen (angular derivative) convention:
Note that some/all of the commits in this PR use a sentence-cased variant, because that was what I was used to. The new standard is lowercase prefixes.