Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ak.from_iter should interpret top-level tuples as ak.Array (v1 and v2). #1642

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

jpivarski
Copy link
Member

This was accidentally the behavior before #1614, and some libraries assumed it. Now the policy is as described in test_1642-from_iter-of-tuples (both v1 and v2).

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #1642 (7192d68) into main (9e17f29) will increase coverage by 0.53%.
The diff coverage is 67.75%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/_v2/_connect/cuda/__init__.py 0.00% <0.00%> (ø)
src/awkward/_v2/_connect/numexpr.py 88.40% <0.00%> (ø)
src/awkward/_v2/_connect/pyarrow.py 88.46% <0.00%> (ø)
...awkward/_v2/_connect/rdataframe/from_rdataframe.py 0.00% <0.00%> (ø)
src/awkward/_v2/_lookup.py 98.68% <ø> (+1.17%) ⬆️
src/awkward/_v2/numba.py 93.47% <0.00%> (ø)
src/awkward/_v2/operations/ak_from_avro_file.py 66.66% <0.00%> (ø)
src/awkward/_v2/operations/ak_local_index.py 100.00% <ø> (ø)
src/awkward/_v2/operations/ak_max.py 87.09% <ø> (ø)
src/awkward/_v2/operations/ak_min.py 87.09% <ø> (ø)
... and 59 more

@jpivarski jpivarski merged commit 352b0de into main Aug 29, 2022
@jpivarski jpivarski deleted the jpivarski/from_iter-of-tuples branch August 29, 2022 18:23
@agoose77
Copy link
Collaborator

Huh, good catch @jpivarski. I hadn't fully appreciated that tuple was special cased in ArrayBuilder. Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants