-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: drop 3.6 support #1661
chore: drop 3.6 support #1661
Conversation
agoose77
commented
Sep 1, 2022
•
edited
Loading
edited
- Replace text references to 3.6 with 3.7 where appropriate
- Remove CI 3.6 special-cases
- Replace manylinux1 with manylinux2014
manylinux2014 support was added in pip 19.3. Python 3.7 ships with pip 20
Bump manylinux version
@jpivarski I've taken the liberty of removing manylinux1 support at the same time, as we only need it for 3.6 as far as I can tell. However, I noticed that our CI was building manylinux1 wheels for 3.6, 3.7, and 3.8. Do you know why that is? It makes me hesitant to remove it. |
Codecov Report
Additional details and impacted files
|
We should probably get a sign-off from @henryiii before merging this (between 1.9.0 and 1.10.0, following #1626 (comment)). The time it takes to release 1.9.0rc13 and 1.9.0 (two releases == 2 days) might correspond to the time when he's back and ready to review things. |
@jpivarski I want to (at some point) rename the CI workflows (both filename and display names):
Maybe we want to move the linting into a new workflow?
Is this PR as good a time as any to do this? |
Yes, this is as good a time as any. By doing it before the git split ( |
It reminds me that I'll have to make two branch protection rules. (I've already done that for Uproot; just forgot about it.) In principle, the test names can differ because the two branches can have different rules, but it will be a lot easier to keep track of if they're not different. (Otherwise, we'd be saying, "main test X corresponds to main-v1 test Y...") |
There are a very small number of users on 3.7 & 3.8 that might have a default pip that can only access manylinux1. They would already be likely to be having some issues, and more in the future. They are also using a version of pip that does not officially support Python 3.7 and 3.8 (it predated those versions) but is forced onto those Pythons (and possibly patched) by linux distro managers. We should also be bumping pyupgrade to 3.7+, and enabling |
I'm going to make a 1.10.0rc1 out of this. The only changes I made were to CONTRIBUTING.md, so I'm not going to wait for the tests to finish. If we need to make any more fixes, it will be 1.10.0rc2. Thanks!!! |