fix: carry parameters through broadcasting #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces new parameter broadcasting modes: - `INTERSECT` - `ONE_TO_ONE` - `ALL_OR_NOTHING` - `NONE` The previous default was `None`. The meaning of these broadcasting modes, set using the `"broadcast_parameters_rule"` option key, can be found in the source code.
Codecov Report
Additional details and impacted files
|
jpivarski
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
We discussed this on Zoom; I think this is a great solution!
The Sentinel will be moving to _util (:checkmark:).
I think the strings should be lower-case, at least when they are arguments to ak.transform (not done yet). It would be fine for the Enums to be upper-case (they're constants) while the strings that represent them are lower-case. It would also be fine to use just strings and not Enums. (This would be the first use of Enum.)
|
OK, I think this is ready to go. I want to, in a future PR, increase the coverage of these test. Right now, we have enough to consider merging this PR. |
agoose77
added a commit
that referenced
this pull request
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1672
@jpivarski and I discussed the ramifications of this on Zoom. We have always been setting the parameters to None in
This PR introduces a new
broadcast_parameters_ruleenumeration that selects from the following rules:"intersect"Take the intersection of the broadcasted input parameters.
"all_or_nothing"Take the first content's parameters if they are equal to all of the other content's parameters, otherwise
None."one_to_one"Assert that the broadcast output matches the broadcast inputs, and if so, take the corresponding parameters (by position).
"none"Always set parameters to
None(previous behaviour)