Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ensure that parameters are kept for NumpyArrays under ufunc operations #1712

Merged
merged 4 commits into from
Sep 24, 2022

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Sep 21, 2022

This follows #1708 to extend the test suite.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #1712 (698dbf9) into main (e692946) will increase coverage by 1.02%.
The diff coverage is n/a.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/__init__.py 96.87% <ø> (ø)
src/awkward/_broadcasting.py 93.41% <ø> (ø)
src/awkward/_connect/avro.py 87.17% <ø> (ø)
src/awkward/_connect/cling.py 24.90% <ø> (ø)
src/awkward/_connect/cuda/__init__.py 0.00% <ø> (ø)
src/awkward/_connect/jax/__init__.py 90.47% <ø> (ø)
src/awkward/_connect/jax/_reducers.py 76.92% <ø> (ø)
src/awkward/_connect/numba/arrayview.py 97.77% <ø> (ø)
src/awkward/_connect/numba/builder.py 81.60% <ø> (ø)
src/awkward/_connect/numba/layout.py 84.87% <ø> (ø)
... and 311 more

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is helpful, but since it only impacts tests, let's merge it after 1.10.1.

@agoose77 agoose77 enabled auto-merge (rebase) September 24, 2022 14:09
@agoose77 agoose77 enabled auto-merge (squash) September 24, 2022 14:16
@jpivarski
Copy link
Member

1.10.1 is done, so this is ready to go!

@agoose77 agoose77 merged commit d9b4387 into main Sep 24, 2022
@agoose77 agoose77 deleted the agoose77/test-numpy-broadcast branch September 24, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants