Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add RegularArray._reduce_next implementation #1811

Merged
merged 15 commits into from
Oct 20, 2022
Merged

feat: add RegularArray._reduce_next implementation #1811

merged 15 commits into from
Oct 20, 2022

Commits on Oct 20, 2022

  1. feat: add RegularArray kernels

    @agoose77
    agoose77 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    27aea68 View commit details
    Browse the repository at this point in the history

  2. feat: add RegularArray._reduce_next impl

    @agoose77
    agoose77 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    4703c36 View commit details
    Browse the repository at this point in the history

  3. feat: make keepdims always add regular dimension

    @agoose77
    agoose77 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    3c7c33a View commit details
    Browse the repository at this point in the history

  4. fix: ensure we convert list-types to ListOffsetArray

    @agoose77
    agoose77 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    c14b9e8 View commit details
    Browse the repository at this point in the history

  5. test: fix tests after change in behavior

    @agoose77
    agoose77 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    6c7c59c View commit details
    Browse the repository at this point in the history

  6. refactor: remove unneeded argsort call 

    This kernel no longer requires post-sorting now that we have no `gaps` kernel.
    @agoose77
    agoose77 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    cf96359 View commit details
    Browse the repository at this point in the history

  7. chore: cleanup duplicate case

    @agoose77
    agoose77 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    b55d989 View commit details
    Browse the repository at this point in the history

  8. test: add test for fixed issue

    @agoose77
    agoose77 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    c745f0a View commit details
    Browse the repository at this point in the history

  9. refactor: simplify IndexedArray._reduce_next

    @agoose77
    agoose77 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    eb6dbda View commit details
    Browse the repository at this point in the history

  10. Update src/awkward/contents/regulararray.py 

    Co-authored-by: Jim Pivarski <[email protected]>
    @agoose77 @jpivarski
    agoose77 and jpivarski authored Oct 20, 2022
    Configuration menu
    Copy the full SHA
    0230794 View commit details
    Browse the repository at this point in the history

  11. refactor: further simplify IndexedArray._reduce_next

    @agoose77
    agoose77 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    a1c57e6 View commit details
    Browse the repository at this point in the history

  12. docs: improve comments for `IndexedOption 

    ._reduce_next`
    @agoose77
    agoose77 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    f66fa21 View commit details
    Browse the repository at this point in the history

  13. Merge remote-tracking branch 'origin/agoose77/fix-proper-regulararray… 

    …' into agoose77/fix-proper-regulararray
    @agoose77
    agoose77 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    52aee95 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'main' into agoose77/fix-proper-regulararray

    @agoose77
    agoose77 authored Oct 20, 2022
    Configuration menu
    Copy the full SHA
    74b8c0a View commit details
    Browse the repository at this point in the history

  15. chore: remove unused _represents_regular flag

    @agoose77
    agoose77 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    7b0133e View commit details
    Browse the repository at this point in the history