Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: allow pushes to main to deploy #1852

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Oct 31, 2022

I noticed that #1836 didn't trigger an RTD build for pushes to main, so I've updated docs.yml

I find the expression NOT (X AND NOT Y) clearer than (NOT X) OR Y because in this case X and Y are related. We only avoid deploying the docs if the event was a PR event, and the PR does not originate from scikit-hep/awkward


📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/agoose77-ci-docs-deploy-on-main/ once Read the Docs has finished building 🔨

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #1852 (bd60862) into main (31ecdf2) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/contents/indexedarray.py 76.60% <0.00%> (-0.19%) ⬇️
src/awkward/contents/recordarray.py 83.87% <0.00%> (-0.19%) ⬇️
src/awkward/_util.py 82.21% <0.00%> (-0.18%) ⬇️
src/awkward/contents/indexedoptionarray.py 88.90% <0.00%> (-0.16%) ⬇️
src/awkward/_connect/avro.py 87.17% <0.00%> (-0.14%) ⬇️
src/awkward/types/_awkward_datashape_parser.py 47.72% <0.00%> (-0.01%) ⬇️

@agoose77
Copy link
Collaborator Author

It's not easy to guarantee that this is working, but if the docs deploy for this PR then we'll know at least that it didn't break anything :)

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I frequently get boolean logic backward, too. But the good thing is that it's easy to notice with a test, since it will either always work or always fail.

I verified that the docs for this branch got pushed, so I guess it worked!

@jpivarski jpivarski merged commit a7e4ef6 into main Oct 31, 2022
@jpivarski jpivarski deleted the agoose77/ci-docs-deploy-on-main branch October 31, 2022 19:51
@agoose77
Copy link
Collaborator Author

For posterity - the docs were deploying on the branch. The problem was that I made an oversight and didn't think about the case where the docs workflow runs on push (not pull_request) to main. In that case, the github.event.pull_request object is null, so the condition always fails. So, let's now see if this merged PR deploys...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants