Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor '_nextcarry-outindex' to have the same signature everywhere #1911

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

ioanaif
Copy link
Collaborator

@ioanaif ioanaif commented Nov 22, 2022


📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/ioanaif-refactor-nextcarry-outindex/ once Read the Docs has finished building 🔨

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #1911 (1ede2d4) into main (3894053) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/contents/bytemaskedarray.py 87.88% <100.00%> (-0.16%) ⬇️

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see; ByteMaskedArray._nextcarry_outindex just didn't need it before. But it's better to be consistent, even if superfluous.

Go ahead and merge, so that you can use this in #1904!

@ioanaif ioanaif merged commit b1e8276 into main Nov 22, 2022
@ioanaif ioanaif deleted the ioanaif/refactor-nextcarry-outindex branch November 22, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants