Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pre-commit hooks #1920

Merged
merged 1 commit into from
Nov 29, 2022
Merged

chore: update pre-commit hooks #1920

merged 1 commit into from
Nov 29, 2022

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Nov 28, 2022

updates:


📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/pre-commit-ci-update-config/ once Read the Docs has finished building 🔨

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #1920 (15b42c4) into main (791d198) will not change coverage.
The diff coverage is n/a.

❗ Current head 15b42c4 differs from pull request most recent head 6b2263e. Consider uploading reports for the commit 6b2263e to get more accurate results

Additional details and impacted files

@jpivarski
Copy link
Member

jpivarski commented Nov 29, 2022

@henryiii, I've tested flake8 6.0.0 for Awkward elsewhere; we weren't depending on any of the API changes we've been hearing about, and that's not responsible for this test failure.

The test failure is on 32-bit Windows, and it seems to be related to Scikit-build: finding a 32-bit compiler.

Installing collected packages: tomli, pyparsing, colorama, pep517, packaging, build
Successfully installed build-0.9.0 colorama-0.4.6 packaging-21.3 pep517-0.13.0 pyparsing-3.0.9 tomli-2.0.1
* Creating venv isolated environment...
* Installing packages in isolated environment... (pybind11, scikit-build-core[pyproject])
* Getting build dependencies for wheel...
* Installing packages in isolated environment... (distlib, pathspec, pyproject_metadata)
* Building wheel...
2022-11-[28](https://github.com/scikit-hep/awkward/actions/runs/3569550846/jobs/5999619731#step:6:29) 23:57:32,066 - scikit_build_core - WARNING - Can't find a Python library, got libdir=None, ldlibrary=None, multiarch=None, masd=None
Warning: Environment variable CMAKE_GENERATOR_PLATFORM will be ignored, because CMAKE_GENERATOR is not set.
loading initial cache file C:\Users\RUNNER~1\AppData\Local\Temp\tmpadhbq8d5\build\CMakeInit.txt
-- Building for: Visual Studio 16 2019
-- The CXX compiler identification is MSVC 19.[29](https://github.com/scikit-hep/awkward/actions/runs/3569550846/jobs/5999619731#step:6:30).[30](https://github.com/scikit-hep/awkward/actions/runs/3569550846/jobs/5999619731#step:6:31)147.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- CMake version 3.25.0
-- CMAKE_BUILD_TYPE = 
-- Found PythonInterp: C:/Users/runneradmin/AppData/Local/Temp/build-env-ccyexqxv/Scripts/python.exe (found suitable version "3.9.13", minimum required is "3.6") 
CMake Error at C:/Users/runneradmin/AppData/Local/Temp/build-env-ccyexqxv/Lib/site-packages/pybind11/share/cmake/pybind11/FindPythonLibsNew.cmake:191 (message):
  Python config failure: Python is [32](https://github.com/scikit-hep/awkward/actions/runs/3569550846/jobs/5999619731#step:6:33)-bit, chosen compiler is 64-bit
-- Configuring incomplete, errors occurred!
Call Stack (most recent call first):
See also "C:/Users/runneradmin/AppData/Local/Temp/tmpadhbq8d5/build/CMakeFiles/CMakeOutput.log".
  C:/Users/runneradmin/AppData/Local/Temp/build-env-ccyexqxv/Lib/site-packages/pybind11/share/cmake/pybind11/pybind11Tools.cmake:50 (find_package)
  C:/Users/runneradmin/AppData/Local/Temp/build-env-ccyexqxv/Lib/site-packages/pybind11/share/cmake/pybind11/pybind11Common.cmake:180 (include)
  C:/Users/runneradmin/AppData/Local/Temp/build-env-ccyexqxv/Lib/site-packages/pybind11/share/cmake/pybind11/pybind11Config.cmake:2[48](https://github.com/scikit-hep/awkward/actions/runs/3569550846/jobs/5999619731#step:6:49) (include)
  CMakeLists.txt:94 (find_package)


*** scikit-build-core 0.1.1 using CMake 3.25.0

*** Configurating CMake...
*** CMake configuration failed

ERROR Backend subprocess exited when trying to invoke build_wheel
Error: Process completed with exit code 1.

Did something change in Scikit-Build very recently? Tests have been succeeding up until this point.

@jpivarski
Copy link
Member

Updating to main gives the test another chance. We'll see if it happens again.

@henryiii
Copy link
Member

Yes, I just released a new version that was supposed to include a patch we needed for conda, and I was fiddling with this part of the code.

Warning: Environment variable CMAKE_GENERATOR_PLATFORM will be ignored, because CMAKE_GENERATOR is not set.

Ahh, that's it, I know what I changed. Kind of weird it used to work with -A, though.

@jpivarski
Copy link
Member

Okay, I'm glad to know that you have leads. Let me know when Scikit-build is ready and we can run our tests again. Thanks!

@henryiii
Copy link
Member

I think this will fix it: scikit-build/scikit-build-core#142

@jpivarski
Copy link
Member

That did fix it, thanks! (Note to @agoose77 that this PR points to a git branch of Scikit-build.) If you'll be releasing it soon, this PR can wait for the release. Otherwise, we'll have to remember to change the the reference to the Scikit-build fix to something more permanent later.

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.4.0](pre-commit/pre-commit-hooks@v4.3.0...v4.4.0)
- [github.com/PyCQA/flake8: 5.0.4 → 6.0.0](PyCQA/flake8@5.0.4...6.0.0)
@henryiii
Copy link
Member

henryiii commented Nov 29, 2022

Already released 0.1.2 (including on conda-forge) and removed the change, was just making sure the fixed worked before shipping it. :)

@jpivarski jpivarski merged commit 4035aca into main Nov 29, 2022
@jpivarski jpivarski deleted the pre-commit-ci-update-config branch November 29, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants