-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update pre-commit hooks #1920
Conversation
Codecov Report
Additional details and impacted files |
@henryiii, I've tested flake8 6.0.0 for Awkward elsewhere; we weren't depending on any of the API changes we've been hearing about, and that's not responsible for this test failure. The test failure is on 32-bit Windows, and it seems to be related to Scikit-build: finding a 32-bit compiler.
Did something change in Scikit-Build very recently? Tests have been succeeding up until this point. |
Updating to |
Yes, I just released a new version that was supposed to include a patch we needed for conda, and I was fiddling with this part of the code.
Ahh, that's it, I know what I changed. Kind of weird it used to work with |
Okay, I'm glad to know that you have leads. Let me know when Scikit-build is ready and we can run our tests again. Thanks! |
I think this will fix it: scikit-build/scikit-build-core#142 |
That did fix it, thanks! (Note to @agoose77 that this PR points to a git branch of Scikit-build.) If you'll be releasing it soon, this PR can wait for the release. Otherwise, we'll have to remember to change the the reference to the Scikit-build fix to something more permanent later. |
updates: - [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.4.0](pre-commit/pre-commit-hooks@v4.3.0...v4.4.0) - [github.com/PyCQA/flake8: 5.0.4 → 6.0.0](PyCQA/flake8@5.0.4...6.0.0)
15b42c4
to
6b2263e
Compare
Already released 0.1.2 (including on conda-forge) and removed the change, was just making sure the fixed worked before shipping it. :) |
updates:
📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/pre-commit-ci-update-config/ once Read the Docs has finished building 🔨