Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consolidate regular indexing #1943

Merged
merged 15 commits into from
Dec 3, 2022
Merged

fix: consolidate regular indexing #1943

merged 15 commits into from
Dec 3, 2022

Commits on Dec 3, 2022

  1. test: add test case

    @agoose77
    agoose77 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    f0c7498 View commit details
    Browse the repository at this point in the history

  2. refactor: normalise_item_RegularArray_to_ListOffsetArray64 should o… 

    …nly be idempotent for 1D arrays
    @agoose77
    agoose77 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    a90dad2 View commit details
    Browse the repository at this point in the history

  3. refactor: add notes about indexing

    @agoose77
    agoose77 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    31d7571 View commit details
    Browse the repository at this point in the history

  4. chore: remove surplus getitem case

    @agoose77
    agoose77 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    819d0a3 View commit details
    Browse the repository at this point in the history

  5. test: correct test case!

    @agoose77
    agoose77 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    8b4bacb View commit details
    Browse the repository at this point in the history

  6. refactor: directly use _to_numpy

    @agoose77
    agoose77 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    9313c37 View commit details
    Browse the repository at this point in the history

  7. fix: normalise purelist_regular RegularArrays to NumPy arrays

    @agoose77
    agoose77 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    92f4cd5 View commit details
    Browse the repository at this point in the history

  8. docs: add comment about types

    @agoose77
    agoose77 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    b9baaf0 View commit details
    Browse the repository at this point in the history

  9. fix: better support mask handling

    @agoose77
    agoose77 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    91ce4c8 View commit details
    Browse the repository at this point in the history

  10. fix: require that fields are lists of strings

    @agoose77
    agoose77 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    b4456fc View commit details
    Browse the repository at this point in the history

  11. chore: rename test

    @agoose77
    agoose77 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    d9bdf81 View commit details
    Browse the repository at this point in the history

  12. test: restore 434 test

    @agoose77
    agoose77 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    25d1bbf View commit details
    Browse the repository at this point in the history

  13. Revert "fix: require that fields are lists of strings" 

    This reverts commit b4456fc.
    @agoose77
    agoose77 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    b243188 View commit details
    Browse the repository at this point in the history

  14. test: ensure that we test all indexing cases

    @agoose77
    agoose77 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    e513ad3 View commit details
    Browse the repository at this point in the history

  15. fix: only return the data of NumpyArray objects

    @agoose77
    agoose77 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    5d38b4b View commit details
    Browse the repository at this point in the history