fix: IndexedArray.project() preserves parameters. #1949

jpivarski · 2022-12-05T18:01:32Z

📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/jpivarski-indexedarray-project-parameters/ once Read the Docs has finished building 🔨

codecov · 2022-12-05T18:07:58Z

Codecov Report

Merging #1949 (9c5f941) into main (65ffb92) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted Files	Coverage Δ
src/awkward/contents/indexedarray.py	`77.64% <100.00%> (+0.05%)`	⬆️
src/awkward/contents/listarray.py	`90.08% <0.00%> (+0.21%)`	⬆️
src/awkward/_util.py	`81.14% <0.00%> (+0.40%)`	⬆️

tests/test_1685-IndexedArray-project-parameters.py

fix: IndexedArray.project() preserves parameters.

5696e6e

jpivarski linked an issue Dec 5, 2022 that may be closed by this pull request

IndexedArray.project() does not preserve parameters #1685

Closed

jpivarski added the pr-next-release Required for the next release label Dec 5, 2022

jpivarski self-assigned this Dec 5, 2022

jpivarski requested a review from agoose77 December 5, 2022 18:04

jpivarski commented Dec 5, 2022

View reviewed changes

tests/test_1685-IndexedArray-project-parameters.py Show resolved Hide resolved

jpivarski commented Dec 5, 2022

View reviewed changes

tests/test_1685-IndexedArray-project-parameters.py Outdated Show resolved Hide resolved

jpivarski and others added 2 commits December 5, 2022 12:17

More testing.

0970112

style: pre-commit fixes

9c5f941

agoose77 approved these changes Dec 5, 2022

View reviewed changes

agoose77 merged commit 248c422 into main Dec 5, 2022

agoose77 deleted the jpivarski/IndexedArray-project-parameters branch December 5, 2022 20:17

jpivarski removed the pr-next-release Required for the next release label Feb 15, 2023