feat: ak.from_rdataframe should accept a single string 'columns'. #1956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a guard, but it also introduces a way of calling
ak.from_rdataframe
(which was already partially in the documentation anyway).It's to be expected that users will sometimes pass a single string into
columns
. When this happens, we couldx
into(x,)
, squashing the distinction between a string and a length-1 tuple of stringsIn this PR, I opted for the third case. It seems to me to be the most useful one.
📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/jpivarski-from_rdataframe-should-accept-a-single-string/ once Read the Docs has finished building 🔨