fix: ak.Record dict constructor should retain type. #1981
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This correction has no effect on the value semantics, just the type semantics:
becomes
In a sense, it also provides symmetry between ak.Array and ak.Record, in that they both have this "Pandas-style" constructor now, but since it's a distinction in values for ak.Array but only types for ak.Record, the effect is a little different.
Anyway, it's nice to get this in before the API freeze because this does change the API.
📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/jpivarski-ak.record-constructor-should-retain-type/ once Read the Docs has finished building 🔨