ci: drop pages deployment #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
temporarily deployed
to
docs-preview
GitHub Actions
Inactive
jpivarski
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
Yes, we should only be generating analytics for the released documentation (main, stable, 2.0, ...) and not PR-branch test-deployments. Removing this will make the data analysis easier later, because we won't have to filter on URLs (if that's even possible for the time-series data).
After this goes through, we should spot-check generated documentation to be sure that
<script data-domain="awkward-array.org" defer="defer" src="https://views.scientific-python.org/js/plausible.js"></script>is in the released documentation and not in the PR-branch test-deployments (whenever there's a new one to check, just take a look to be sure).
|
I suppose this PR is the first thing that can be tested: the line of HTML is not in http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/agoose77/docs-switch-to-aws/, so that's good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should remove the GitHub Pages documentation deployment from the CI, and disable version selectors for previews.