fix: support UnknownLength in ak.types.ArrayType
#2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
changed the title
ak.types.ArrayTypeUnknownLength in ak.types.ArrayType
agoose77
temporarily deployed
to
docs-preview
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files
|
agoose77
temporarily deployed
to
docs-preview
GitHub Actions
Inactive
jpivarski
approved these changes
Dec 22, 2022
Comment on lines
+18
to
+24
| if not ( | ||
| (ak._util.is_integer(length) and length >= 0) | ||
| or length is ak._typetracer.UnknownLength | ||
| ): | ||
| raise ak._errors.wrap_error( | ||
| ValueError( | ||
| "{} 'length' must be of a positive integer, not {}".format( | ||
| "{} 'length' must be a non-negative integer or unknown length, not {}".format( |
|
I've been putting a little time between approval and merging by collecting these into a browser window, reviewing them one after another, and then going back to the beginning to merge them. Now I'm back around to the end of the list, so I'll merge this. |
|
Ah, sorry @ioanaif! I didn't assign the issue to myself because I noticed that it was fairly small. I'll make a note to be better at always assigning things I'm working on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1937