Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: soft-deprecate flatten_records instead of hard-deprecation #2036

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

agoose77
Copy link
Collaborator

No description provided.

@agoose77 agoose77 changed the title fix: soft-deprecate flatten_records instead of hard-deprecation fix: soft-deprecate flatten_records instead of hard-deprecation Dec 23, 2022
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #2036 (96fdfef) into main (bd3efcc) will decrease coverage by 0.29%.
The diff coverage is 0.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/operations/ak_all.py 80.00% <0.00%> (-14.12%) ⬇️
src/awkward/operations/ak_any.py 80.00% <0.00%> (-14.12%) ⬇️
src/awkward/operations/ak_argmax.py 60.00% <0.00%> (-15.00%) ⬇️
src/awkward/operations/ak_argmin.py 60.00% <0.00%> (-15.00%) ⬇️
src/awkward/operations/ak_corr.py 74.19% <0.00%> (-7.95%) ⬇️
src/awkward/operations/ak_count.py 78.94% <0.00%> (-14.81%) ⬇️
src/awkward/operations/ak_count_nonzero.py 80.00% <0.00%> (-14.12%) ⬇️
src/awkward/operations/ak_covar.py 73.07% <0.00%> (-9.54%) ⬇️
src/awkward/operations/ak_max.py 60.00% <0.00%> (-15.00%) ⬇️
src/awkward/operations/ak_mean.py 52.77% <0.00%> (-10.56%) ⬇️
... and 8 more

@agoose77 agoose77 force-pushed the agoose77/fix-soft-deprecate-flatten-records branch from 2967a5e to 96fdfef Compare December 23, 2022 19:11
@agoose77 agoose77 temporarily deployed to docs-preview December 23, 2022 19:19 — with GitHub Actions Inactive
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should fix dask-contrib/dask-awkward#136 (comment), assuming that dask-awkward doesn't have "warnings as errors" turned on!

I'll push this through to a new release.

@jpivarski jpivarski merged commit 93da9bc into main Dec 23, 2022
@jpivarski jpivarski deleted the agoose77/fix-soft-deprecate-flatten-records branch December 23, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants