Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct docstring for ak.metadata_from_parquet #2050

Merged
merged 2 commits into from
Dec 31, 2022

Conversation

agoose77
Copy link
Collaborator

No description provided.

@agoose77 agoose77 changed the title docs: correct docstring for metadata_from_parquet docs: correct docstring for ak.metadata_from_parquet Dec 31, 2022
@codecov
Copy link

codecov bot commented Dec 31, 2022

Codecov Report

Merging #2050 (8e5482c) into main (9ab248c) will decrease coverage by 1.20%.
The diff coverage is 100.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/operations/ak_metadata_from_parquet.py 100.00% <100.00%> (ø)
src/awkward/operations/ak_argmax.py 60.00% <0.00%> (-31.18%) ⬇️
src/awkward/operations/ak_argmin.py 60.00% <0.00%> (-31.18%) ⬇️
src/awkward/operations/ak_sum.py 60.00% <0.00%> (-30.33%) ⬇️
src/awkward/operations/ak_prod.py 60.00% <0.00%> (-30.33%) ⬇️
src/awkward/operations/ak_max.py 60.00% <0.00%> (-28.24%) ⬇️
src/awkward/operations/ak_min.py 60.00% <0.00%> (-28.24%) ⬇️
src/awkward/operations/ak_count.py 78.94% <0.00%> (-21.06%) ⬇️
src/awkward/operations/ak_softmax.py 78.94% <0.00%> (-21.06%) ⬇️
src/awkward/operations/ak_all.py 80.00% <0.00%> (-20.00%) ⬇️
... and 39 more

@agoose77 agoose77 temporarily deployed to docs-preview December 31, 2022 01:43 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs-preview December 31, 2022 02:26 — with GitHub Actions Inactive
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this consistent! At one point, the function really did return the Parquet metadata as-is, but I can see in the out variable that it's no longer true.

This can be merged when you're done with it.

@agoose77
Copy link
Collaborator Author

@jpivarski yes I recall that too! I think this is correct now - I'm literally reading the implementation.

@agoose77 agoose77 merged commit eb9e5de into main Dec 31, 2022
@agoose77 agoose77 deleted the agoose77/docs-metadata-from-parquet branch December 31, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants