Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove reference to sorting implementation #2114

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

agoose77
Copy link
Collaborator

We don't want users to worry about the specific sorting algorithm being used, so here we hide the implementation details. I'm also fairly sure these are old docs - we use std::stable_sort and std::sort on CPU as of writing, which is mergesort and introsort respectively

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #2114 (86f1c1d) into main (54ab9f3) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/operations/ak_argsort.py 75.00% <ø> (ø)
src/awkward/operations/ak_sort.py 60.00% <ø> (ø)

@agoose77 agoose77 temporarily deployed to docs-preview January 12, 2023 20:46 — with GitHub Actions Inactive
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to say exactly what we mean!

I'll set auto-merge.

@jpivarski jpivarski enabled auto-merge (squash) January 12, 2023 21:00
@jpivarski jpivarski merged commit e3f2213 into main Jan 12, 2023
@jpivarski jpivarski deleted the agoose77/docs-sorting-kind branch January 12, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants