Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: disable IPyParallel & load dependencies in reverse order #2126

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

agoose77
Copy link
Collaborator

I've noticed intermittent failures in the "Try It" demo; sometimes we get a symbol definition error. However, it transpires that re-running the import fixes this. I added an explicit import for awkward-cpp that appears to fix the issue.

This PR also disables IPyParallel, which is a nuisance.

@agoose77 agoose77 temporarily deployed to docs-preview January 16, 2023 12:25 — with GitHub Actions Inactive
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better for the "Try it!" experience to be stable and robust. It's probably fine for it to be a little slower; maybe most users (right now) understand that running Python in a browser is a different, less performant platform than regular CPython.

Also, I'm surprised that a parallel-processing extension would have any kind of speedup in a browser, which is async but not parallel. It's still the case that the installations use the await keyword.

@agoose77
Copy link
Collaborator Author

I think IPyParallel is just a default extension that gets installed with IPython(?) I've not dug into where it comes from in great depth. In any case, we weren't using it, but it was causing a noisy popup that the server extension wasn't loaded!

@agoose77 agoose77 merged commit 0203ee6 into main Jan 16, 2023
@agoose77 agoose77 deleted the agoose77/docs-fix-try-it-loading branch January 16, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants