Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: more Ruff #2184

Merged
merged 7 commits into from
Feb 17, 2023
Merged

chore: more Ruff #2184

merged 7 commits into from
Feb 17, 2023

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Feb 1, 2023

  • chore: some Ruff additions
  • chore: minor adjustment to Ruff
  • chore: ruff iterable merging
  • chore: RUF codes enabled

@henryiii henryiii temporarily deployed to docs-preview February 1, 2023 03:55 — with GitHub Actions Inactive
@henryiii henryiii marked this pull request as draft February 1, 2023 04:14
@codecov
Copy link

codecov bot commented Feb 1, 2023 •
edited
Loading

Codecov Report

Merging #2184 (1c5a19e) into main (a5dc78c) will decrease coverage by 0.01%.
The diff coverage is 76.25%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/_connect/numba/layout.py 83.37% <ø> (ø)
src/awkward/_connect/rdataframe/from_rdataframe.py 0.00% <0.00%> (ø)
src/awkward/behaviors/categorical.py 74.64% <0.00%> (ø)
src/awkward/forms/bitmaskedform.py 88.50% <ø> (ø)
src/awkward/forms/bytemaskedform.py 87.65% <ø> (ø)
src/awkward/forms/listform.py 83.14% <0.00%> (ø)
src/awkward/forms/unionform.py 81.95% <0.00%> (ø)
src/awkward/operations/ak_mask.py 95.65% <ø> (ø)
src/awkward/operations/ak_to_dataframe.py 90.47% <ø> (ø)
src/awkward/types/scalartype.py 77.27% <0.00%> (ø)
... and 24 more

@henryiii henryiii temporarily deployed to docs-preview February 1, 2023 15:08 — with GitHub Actions Inactive
@henryiii henryiii temporarily deployed to docs-preview February 1, 2023 15:44 — with GitHub Actions Inactive
agoose77
agoose77 reviewed Feb 1, 2023
View reviewed changes
dev/generate-kernel-signatures.py
Comment on lines +96 to +97
"awkward_reduce_sum_int32_bool_64",
"awkward_reduce_sum_int64_bool_64",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes! Nice catch.

Copy link
Member Author

@henryiii henryiii Feb 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what linters are for. :) (though Black helps here too by making it easy to see by eye, if someone was looking)

My hand rewrite of the template code is still slightly off, will have to find where things changed.

@henryiii henryiii marked this pull request as ready for review February 16, 2023 16:18
@agoose77 agoose77 enabled auto-merge (squash) February 17, 2023 08:02
@pre-commit-ci pre-commit-ci bot temporarily deployed to docs-preview February 17, 2023 08:18 Inactive
@agoose77 agoose77 merged commit 4e01cc4 into main Feb 17, 2023
@agoose77 agoose77 deleted the henryiii/chore/ruff5 branch February 17, 2023 08:20
@jpivarski jpivarski mentioned this pull request Feb 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agoose77 agoose77 agoose77 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryiii @agoose77