Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include cuda kernel tests in sdist #2218

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Feb 7, 2023

Hatchling ignores anything that is ignored by the VCS by default. We can use artefacts to explicitly include e.g. the generated CUDA kernel tests.

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #2218 (3a7dec8) into main (339896f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
Impacted Files Coverage Δ
...rc/awkward/operations/ak_merge_union_of_records.py 88.70% <ø> (ø)

@agoose77 agoose77 temporarily deployed to docs-preview February 7, 2023 12:05 — with GitHub Actions Inactive
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take your word for it!

(Sounds like a terrible review, doesn't it? But in this PR, it's clear that you just needed to move tests-cuda-kernels from one category to another for some technical reason in hatchling. The evidence that it was the right thing to do is that it got those header files into the package, and not doing this didn't. Current tests wouldn't have been sensitive to that change, since we're not routinely testing CUDA kernels yet.)

"src/awkward/_connect/header-only"
"/src/awkward/_connect/header-only"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src is not in the root of the filesystem, but I suppose this filename path is interpreted by hatchling to be relative to the base of the package or source repo.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, Hatchling uses Git-style glob pattern to match these entries. This doesn't "fix" any bugs, but it's good to be explicit that we're talking about one src directory only :)

@agoose77
Copy link
Collaborator Author

agoose77 commented Feb 7, 2023

Sounds like a terrible review, doesn't it?

Haha, sometimes less is more!

@agoose77 agoose77 merged commit 2dff3f2 into main Feb 7, 2023
@agoose77 agoose77 deleted the agoose77/chore-include-cuda-tests branch February 7, 2023 17:05
@agoose77 agoose77 changed the title chore: include cuda kernels in sdist chore: include cuda kernel tests in sdist Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants