fix: boolean slicing with non-packed arrays #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
changed the title
agoose77
commented
Feb 15, 2023
Comment on lines
+530
to
533
| raise wrap_error( | ||
| TypeError("This slice is not supported for JAX differentiation.") | ||
| ) | ||
| # missing values as any integer other than -1 are extremely rare |
There was a problem hiding this comment.
Unrelated change.
Codecov Report
Additional details and impacted files
|
agoose77
temporarily deployed
to
docs-preview
GitHub Actions
Inactive
jpivarski
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fixing #2214, I missed the fact that
to_ListOffsetArray64(True)provides no guarantee about the length of the content. This PR fixes that oversight, by usingak._do.flattenwhich ensures the length of the result is correct.