-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Numba CUDA guide (#2260) #2260
Conversation
@agoose77 - I'm not sure if I need to link it. Please, have a look. Thanks! |
Codecov Report
Additional details and impacted files
|
We need to think about how to deploy these docs; we don't have a CUDA-enabled runner currently in-action. My current thinking is that we might be able to deploy only the CUDA docs from e.g. a scheduled CUDA worker. This would push an It's not a perfect solution, and for now we can just do this manually. |
@ianna I changed the result to be a CuPy array instead of Numba. The reason for this is that |
I'm actually updating the PR with a better example :-) |
I didn't notice this before I clicked "Update branch", so be sure to (I wanted to see if the "Build Docs" failure is the same everywhere, or if it's only in #2268.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I streamlined the text and code samples to make them easier to learn from. But on the whole, it's a very good tutorial!
I'm assuming that the reason it's a notebook (ipynb file) rather than Jupytest (md file) is because it must not be allowed to run on the CI, due to the dependence on a GPU. If that's the reason, it makes sense to me.
Feel free to merge it when you're ready.
Yes, the file is an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpivarski - thanks, it looks great! I don't know why the tests are not finished - but before they do I cannot merge it.
Tests don't run for non-code changes! I can merge this, then :) |
No description provided.