-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apply subset of fixes for downstream dask usage #2283
Conversation
d5b1755
to
6cde4b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, although there's at least one use of to_rectilinear
in the tests, which is where this is failing right now.
assert nplike.to_rectilinear(array).tolist() == ak_array.to_list() |
len(nextinputs[0]) + 1, dtype=np.int64 | ||
nextinputs[0].length + 1, dtype=np.int64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, although there's at least one use of
to_rectilinear
in the tests, which is where this is failing right now.
assert nplike.to_rectilinear(array).tolist() == ak_array.to_list()
I could have sworn I ran the test suite locally. Oh, well, thank goodness for CI!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It came up in the Linux-ROOT test; it might be a test that requires ROOT in the specific environment to run. Although I see that another one failed, too, so maybe not.
In c569a71, I simply removed the failing test. It was testing an aspect of |
Codecov Report
Additional details and impacted files
|
TL;DR
cumsum
toTypeTracer
to_rectilinear
from nplikes, replaces withlayout.to_backend_array