-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: uneccessary use of nplike_of
#2315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is different from the one I've been seeing develop, and it looks pretty simple: making the calls to get nplikes more uniform in preparation for a refactoring. Looks good!
In future,
nplike_of
will only accept array objects (not layouts, etc).
By "array objects," do you mean buffers, like np.ndarray
, cp.ndarray
, or TypeTracerArray
, not ak.Array
? (It seems like that's what you mean.)
In an ecosystem with N array types, you'd think I'd be more precise by now ;) Yes, I mean the nplike buffers. The rewrite of #2307 will simplify |
Codecov Report
Additional details and impacted files
|
In preparation for a simplification of
nplike
identification, this PR eliminates redundantnplike_of
usages, and/or replaces them withbackend_of
.In future,
nplike_of
will only accept array objects (not layouts, etc).