-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add to_cudf #3051
feat: Add to_cudf #3051
Conversation
I think we intended to come back to this PR and implement string conversion? At the moment, you have the following behaviour:
I'm not entirely sure why the two routes are different, but either way we do need this to work. This PR is pinned to release 2.6.3, so it's also slipped behind the main branch, and we could do with some plan to complete it. |
@jpivarski , probably plenty of work left here and classes not covered, but I thought you would like to have a look, now that I have at least a few tests. |
Missing: IndexedArray; does this map to categorical? |
IndexedArray is only mapped to Arrow's categorical ("dictionary") if |
This works also for time types, without going via cupy
@jpivarski , this PR is still languishing here. What do you think is needed to get it released, at least in experimental form? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the import cupy
was removed from top-level imports. (Anyway, tests wouldn't pass without that.) This all looks good—I don't know why I didn't see it when I was scanning through the open PRs for any that had been waiting.
I also just tested tests-cuda on my GPU, and everything passes.
So I'll merge it!
This reverted commit I could not quickly tell if this was intentional or accidental from the commits in this PR. |
#3249 to fix it. |
It was accidental. Thanks! |
Not too much here yet, just started writing out the template to let others get involved