Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a link to documentation of AwkwardArray in Julia #3052

Merged
merged 6 commits into from
Mar 20, 2024

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Mar 14, 2024

AwkwardArray in Julia documentation is created by Documenter.jl.

Copy link
Collaborator Author

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpivarski - I'm not sure why the packaging test on ubuntu fails.

docs/index.md Show resolved Hide resolved
@agoose77
Copy link
Collaborator

@ianna looks like we're pulling in a NumPy beta, which is not yet supported!

@jpivarski
Copy link
Member

For now, we can ignore that test failure (or prevent NumPy 2.0.0b1 from being installed, only to have to reverse it later?), particularly for this PR, which is a documentation PR.

@tcawlfield is looking into #2936 right now. Hopefully, the changes needed are small and can be confined to nplike. The first issue, numpy.AxisError moving to some other path, would be easy to fix. Before making major changes, like putting an upper cap on NumPy version, we need to get a sense of how many issues there are and how long it will take.

@jpivarski
Copy link
Member

Note to self: I want to find a three-dots inline Julia icon, as a replacement for the

{fas}`history`

If neither of us can find such a thing, we can call this PR done.

@ianna
Copy link
Collaborator Author

ianna commented Mar 20, 2024

I only found an ellipsis icon among {fas}

@jpivarski
Copy link
Member

Ha! It worked!

image

I'd say it's ready to merge now. The tests won't all run, since this PR doesn't touch code.

@jpivarski jpivarski merged commit b45c312 into main Mar 20, 2024
18 checks passed
@jpivarski jpivarski deleted the ianna/docs_card_to_awkward_in_julia branch March 20, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants