-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add boolean cases for CPU kernels #3059
Conversation
…rray_getitem_jagged_shrink
2ee57a9
to
9dcee2d
Compare
@jpivarski I had removed |
As usual, replacing kernels with NumPy/CuPy equivalents is a good thing to do, and I don't want to return to the custom kernel now that this mostly works. One error, with the BitMaskedArray, might be because the whole For the missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verify that the CUDA tests all pass. All that's left is to fix the old-NumPy case (np.unique
not having an equal_nan
argument), and then this will be ready to merge.
This looks like it's done. If so, please merge it. Thanks! |
Removed the following CPU Kernels and replaced their implementation with Numpy/Cupy -
Added boolean cases for same kernels
Fixed and added some CUDA kernels
Tests!