fix: distributed rdataframe is not yet support #3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpivarski - is someone looking into pypy segfaults? Thanks |
Not at the moment. If you have a chance to look into #2971, that would be great. |
ianna
commented
Apr 25, 2024
There was a problem hiding this comment.
@jpivarski - as discussed yesterday we are making it clear that distributed RDataFrame is not supported yet.
jpivarski
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
If only distributed RDataFrames have the proxied_node attribute, this is a good way to catch it. It sounds like that might be true, but would checking the data type be more robust? E.g.
if type(data_frame).__name__ == "DistributedRDataFrame":or something similar?
Either way, this is good to merge. I'll let you decide how to handle it.
ianna
deleted the
ianna/3061-from_rdataframe-does-not-work-for-distributed-rdataframe
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a clear message