Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip failing test when jax is not installed #3112

Merged
merged 2 commits into from
May 13, 2024
Merged

fix: skip failing test when jax is not installed #3112

merged 2 commits into from
May 13, 2024

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented May 13, 2024

No description provided.

ianna
ianna commented May 13, 2024
View reviewed changes
Copy link
Collaborator Author

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpivarski - the test checked only if numba is present, but not jax.

@ianna ianna requested a review from jpivarski May 13, 2024 14:27
jpivarski
jpivarski approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely necessary. Thanks for catching it!

I'll also just merge it because it's a simple enough PR that I know you're not adding to it right now.

@jpivarski jpivarski merged commit d5f6925 into main May 13, 2024
41 checks passed
@jpivarski jpivarski deleted the ianna/skip_jax_test_if_no_jax_installed branch May 13, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianna @jpivarski