Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add slicing CUDA kernels #3140

Merged
merged 7 commits into from
Jun 5, 2024
Merged

feat: add slicing CUDA kernels #3140

merged 7 commits into from
Jun 5, 2024

Conversation

ManasviGoyal
Copy link
Collaborator

No description provided.

@ManasviGoyal ManasviGoyal added the gpu Concerns the GPU implementation (backend = "cuda') label Jun 4, 2024
@ManasviGoyal ManasviGoyal mentioned this pull request Jun 4, 2024
Merged
21 tasks
@ManasviGoyal ManasviGoyal marked this pull request as ready for review June 5, 2024 11:42
jpivarski
jpivarski approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This passes all tests on my GPU.

It's also (almost) purely adding code, rather than removing any.

The new kernels look good to me.

Go ahead and merge it!

@ManasviGoyal ManasviGoyal merged commit 81085be into main Jun 5, 2024
41 checks passed
@ManasviGoyal ManasviGoyal deleted the ManasviGoyal/slicing-kernels branch June 5, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
gpu Concerns the GPU implementation (backend = "cuda')
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ManasviGoyal @jpivarski