Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test from_raggedtensor on GPU #3288

Merged
merged 2 commits into from
Oct 31, 2024
Merged

fix: test from_raggedtensor on GPU #3288

merged 2 commits into from
Oct 31, 2024

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Oct 31, 2024

make sure the backend of the reference array is the same as the result's

@ianna ianna requested a review from jpivarski October 31, 2024 14:29
jpivarski
jpivarski approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is an important fix! I'll merge it.

In this git-branch, pytest tests-cuda still runs. ✔️

@jpivarski jpivarski merged commit 3fd561a into main Oct 31, 2024
44 checks passed
@jpivarski jpivarski deleted the ianna/fix_test_raggedtensor_on_gpu branch October 31, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianna @jpivarski