-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArrayBuilder refactoring #977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpivarski - please, check if it's going in the right direction. Thanks.
… c++ tests are deleted and the json parser is refactored Please enter the commit message for your changes. Lines starting
…o it are done via pybind11
9716a3e
to
0b498db
Compare
@jpivarski - the last commit was a minor cleanup, so I assume the tests will pass. Please, have a look when you have time. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I scanned through everything and marvel at how many things used to refer to Content but didn't really need to (including in the documentation).
About deleting "dependent project," I had thought that we'd just disable it, but I like your idea of actually deleting it. It's best to be clear that the capability is going away.
I also like the idea of concentrating transitional code in include/awkward/refactoring.h, so that we can find it again when the transition is complete.
Let's merge it! You can do the honors (pushing the "enable squash-and-merge" button), in case you have any last changes.
*::snapshot
methods that depended onContent
classes to abuilder_snapshot(const ak::Builder& builder)
function invoked incontent.cpp
to be handled viapybind11
- [ ] moveArrayBuilder::append
methods to be handled viapybind11
as discussed, this one is needed for numba and will be revisited later
RawArray
class