fix: Uproot tests now work with Awkward 2.0.0. #795
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works offline with dask-awkward from its
main
branch, but the tests will still fail until a dask-awkward release is made containing dask-contrib/dask-awkward#119. We just need a dask-awkward 2022.12a3, @douglasdavis.I'm impressed that the
parse_version("1") < parse_version(awkward.__version__) < parse_version("2")
line survived this long in Uproot v5. I simply misunderstood what "< parse_version("2")
meant: I must have thought that it excluded all the 2.0.0rcX pre-releases, but that's not how version ordering works. Okay. The version range has been fixed, and it no longer has an upper cap. (We have no reason to believe that there will be an Awkward 3.x, or that it might be disruptive.)The other "fix", twiddling how the tests get data out of an Awkward Array, side-steps the bug that is fixed in scikit-hep/awkward#1993 (and now there's an Awkward test for it, so we don't rely on Uproot's test).
Uproot 5.0.0 can't be released until this is merged and this can't be merged until dask-awkward 2022.12a3 exists. But we don't need scikit-hep/awkward#1993; this PR is independent of that reaching a release. That's the order of dependencies.