Fix build for ARM 32 bit #3129
Merged
Fix build for ARM 32 bit #3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antl had a problem with ARM 32: antlr/antlr4#1858 So picking the commit of antlr where the PR scionproto#1990 was merged. Also casting a constant to uint64 (see default type of an untyped constant https://golang.org/ref/spec#Constants ).
lukedirtwalker
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
juagargi
added a commit
to netsec-ethz/scion
that referenced
this pull request
Sep 10, 2019
ANTLR had a problem with ARM 32: antlr/antlr4#1858 So we take v4.7.2 of ANTLR which fixes the issue. Also use AS and ISD types for Max constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ANTLR had a problem with ARM 32:
antlr/antlr4#1858
So we take v4.7.2 of ANTLR which fixes the issue.
Also use AS and ISD types for Max constants.
This change is