Print names of events and current stage #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmghannam
requested changes
Dec 21, 2023
Co-authored-by: Mohammed Ghannam <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #769 +/- ##
==========================================
+ Coverage 61.55% 61.68% +0.13%
==========================================
Files 16 16
Lines 3238 3255 +17
==========================================
+ Hits 1993 2008 +15
- Misses 1245 1247 +2 ☔ View full report in Codecov by Sentry. |
mmghannam
approved these changes
Dec 28, 2023
mmghannam
reviewed
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
model.getStage()we get an integer, not very informative. We now havemodel.getStageName(), which gives us the name of the stage. Same for events. This does not solve #766, as directly trying to print an event should still give an error. Similar to PR #484.Draft because I'm sure there are better ways to do this.