Revert "Type loop variables" #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bd85238.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #789 +/- ##
=======================================
Coverage 61.68% 61.68%
=======================================
Files 16 16
Lines 3255 3255
=======================================
Hits 2008 2008
Misses 1247 1247 ☔ View full report in Codecov by Sentry. |
mmghannam
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #758
Explicitly typing variables can lead to errors.
See the following:
The difference is bigger than SCIP's default machine epsilon, so we decided to revert these changes for now. Maybe the best option is to only type our custom types (like Variables, Expressions, etc.), which shouldn't be a problem. We lose the marginal speedup from Cython, but we still get a more robust codebase.