Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinearCombination.java evaluate method #11

Open
alexpArtos opened this issue Mar 19, 2019 · 0 comments
Open

LinearCombination.java evaluate method #11

alexpArtos opened this issue Mar 19, 2019 · 0 comments

Comments

@alexpArtos
Copy link

Hi all,

I think there is a problem with the evaluate() method in relations.objects.LinearCombination.
This line seems fishy if the condition is true:

final FieldT value = index == 0 ? one : input.get((int) index).mul(terms.get(i).value());

If index == 0, we want to add the constant value of the linear combination, which should be
terms.get(i).value(), not one.

doutv pushed a commit to doutv/dizk that referenced this issue Jul 5, 2023
Include Docker File and update readme for docker build guide.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant