Clean up build warnings #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several variables are used only in assertions. In release builds those assertions get optimized out leaving otherwise unused variables behind resulting in unused-but-set-variable warnings. This commit applies the UNUSED() utility already defined in libff for this purpose. Signed-off-by: Dan Middleton <[email protected]>
|
Compare build output of this PR vs. recent master |
ValarDragon
approved these changes
Aug 25, 2020
ValarDragon
pushed a commit
that referenced
this pull request
Sep 25, 2020
Several variables are used only in assertions. In release builds those assertions get optimized out leaving otherwise unused variables behind resulting in unused-but-set-variable warnings. This commit applies the UNUSED() utility already defined in libff for this purpose. Signed-off-by: Dan Middleton <[email protected]> Merged-by: Dev Ojha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several variables are used only in assertions. In release builds those
assertions get optimized out leaving otherwise unused variables behind
resulting in unused-but-set-variable warnings. This commit applies the
UNUSED() utility already defined in libff for this purpose.
This likewise cleans up downstream builds in projects consuming libff such as libsnark.