-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cofactors to non-edwardian curve interfaces #50
Conversation
@ValarDragon I changed the target branch back to Note: We'd need to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! Sorry for the delayed review. I think its good to merge into staging, and then we can make a new release
These sage scripts will probably be very useful!
/cc @Pratyush would it be useful to have code to generate C++ and Rust curve code based off this type of sage file?
I'm not sure what the edwards code is for, and 80 bits of security doesn't seem useful for anything anymore. Maybe the idea of this curve was to have an Edwards curve model, which can be constructed from the scalar field? If so, we should probably deprecate the existing curve and demonstrate it on jub-jub. (And be sure to not have it implement the pairing interface) |
I believe the special thing about these Edwards curves is that they’re pairing friendly |
Do you have any thoughts about whether pairing friendly edwards curves are useful/should be maintained? I don't know of anyone using it, nor do I know of a concrete reason to not use them for BLS. |
* Added cofactors to non-edwardian curve interfaces * Added mnt sage script * Added more sage and fixed mnt4 g2 cofactor
Proposal to address #45
Question: What is the security provided by the edward curve? It is documented that it provides 80 bits of security, but is that still the case today? Would there be a reason to remove this curve from the lib? (this is outside of the scope of this PR of course)