Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of MPIR instead of GMP #61

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

yperbasis
Copy link
Contributor

GMP is not compatible with Windows, while its fork MPIR is.

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good change to me, but I haven't looked into MPIR in detail yet.

I don't have convenient access to a windows computer at the moment, does the library build on windows with this?

Is building on Windows something you've had to look into @AntoineRondelet ?

@yperbasis
Copy link
Contributor Author

MPIR is a fork of GMP and is also available on Linux/macOS. I can build libff fine on Windows with MPIR. There was one issue due to the fact that long is 32 bit on Windows even in the 64-bit mode (unlike Linux). I've raised PR #59 to fix that.

@AntoineRondelet
Copy link
Collaborator

AntoineRondelet commented Sep 7, 2020

Is building on Windows something you've had to look into @AntoineRondelet ?

No, unfortunately I haven't looked into that, and am not knowledgeable (at all) about Windows.


Thanks @yperbasis for the PR. I would keep this PR open for the time being as the CI is not comprehensive enough to safely support multiple OSes and architectures. As such, I would be in favor to first: Add windows build to the CI (e.g. https://docs.travis-ci.com/user/reference/windows/ or https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md), and then (and only then) consider merging Windows related PRs.

Note that, macOS is not part of the CI either. We need to add that.
I'll open a ticket to extend the CI [EDIT:] Here's the ticket #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants