Fix incompatible requirements #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Not adding 3.12-dev because --only-binary installs not yet possible.
h-vetinari
force-pushed
the
fix-incompatible-requirements
branch
from
5496c13
to
f393a4a
Compare
h-vetinari
reviewed
Jun 22, 2023
Comment on lines
+26
to
+27
| numpy==1.16.0; python_version=='3.6' and platform_system=='AIX' and (platform_machine=='loongarch64' or platform_machine!='aarch64' and platform_python_implementation != 'PyPy') | ||
| numpy==1.16.0; python_version=='3.7' and platform_system=='AIX' and (platform_machine=='loongarch64' or platform_machine!='aarch64' and platform_python_implementation != 'PyPy') |
There was a problem hiding this comment.
I don't fully understand yet why this condition is necessary, but if you're mixing and and or, please add brackets, so we don't have to do operator precedence in our heads.
|
I have a more comprehensive fix in #74, which expands testing to ensure that even invalid combinations don't get more than one pin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #70
For each pair of incompatible requirements, I assumed that the higher required numpy is the correct one. Thus, I added the inverted marker of this requirement to the marker of the other requirement. I repeated this process (and simplified the resulting markers if possible) until all conflicts detected by Poetry were resolved.
Of course, there are other options to eliminate the incompatible requirements, so someone with more expertise in this topic should check carefully if my changes make sense.