Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid retrying for 5 minutes after failed key retrieval. #102

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid retrying for 5 minutes after failed key retrieval. #102

wants to merge 2 commits into from

Commits on Nov 1, 2022

  1. Avoid retrying for 5 minutes after failed key retrieval 

    Without this, a persistent failure in the key retrieval will not
be remembered, meaning rapid-fire retries from the client will result
in a similar number of key retrieval attempts.

This causes the next_update to be set forward by 5 minutes after each
failure.
    @bbockelm
    bbockelm committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    7ec2670 View commit details
    Browse the repository at this point in the history

  2. Unit test coverage for failed issuer 

    Test the behavior around an issuer failure -- as long as the cached
pubkey isn't expired, we shouldn't try again for 5 minutes.
    @bbockelm
    bbockelm committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    2f14506 View commit details
    Browse the repository at this point in the history