-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth2 discovery versus OIDC discovery #75
Comments
SciTokens should use OAuth Discovery, since SciTokens is OAuth, not OIDC. Similar issue in scitokens-java. |
But even there, we have:
Whereas the OAuth discovery (and RFC 5785) says this should be:
|
Brian, I guess you're referring to https://tools.ietf.org/html/draft-ietf-oauth-discovery-10#section-3.1 and https://tools.ietf.org/html/draft-ietf-oauth-discovery-10#section-5 which discusses how to form the discovery URI when the issuer contains a path component? I don't see anything about .well-known/oauth-authorization-server/issuer in https://tools.ietf.org/html/rfc5785. It seems clear to me. issuer = https://scitokens.org/ issuer = https://scitokens.org/ligo Personally I find https://tools.ietf.org/html/draft-ietf-oauth-discovery-10#section-5 a bit of a mess, so I'd strongly recommend against issuers containing path components to avoid that particular mess. I think there's a decent chance that will change before the RFC is published. |
Following the example at https://tools.ietf.org/html/rfc5785#section-3:
In our case, the application name is "oauth-authorization-server" so if our issuer is "https://scitokens.org/" then we get "https://scitokens.org/.well-known/oauth-authorization-server". |
You're right - RFC 5785 doesn't really touch this, other than being fairly clear that What's your feeling of the status of the OAuth Discovery document? The WLCG folks were reluctant to follow it as it's still a draft. Given the implementations being considered on the WLCG side are also OIDC clients, there was a strong preference to utilize OIDC mechanisms. |
https://datatracker.ietf.org/doc/draft-ietf-oauth-discovery/ shows it is far along in the process. The change to the URI form for issuers containing path components happened recently during IESG review for BCP 190 conformance. It's farther along than https://datatracker.ietf.org/doc/draft-ietf-oauth-token-exchange/ which we're already depending on. Given the feedback from WLCG, I'm guessing SciTokens needs to support both OIDC and OAuth discovery, with OAuth discovery as our recommended/preferred approach, since I think we want to avoid any explicit dependencies on OIDC (according to our "SciTokens is OAuth, not OIDC" principle). |
I think that as long as our libraries try the OAuth2 mechanism and fall back to OIDC, we should be fine. If I parsed yesterday's conversation correctly (they haven't updated the working docs to reflect the discussion), WLCG will do the same once the OAuth2 discovery mechanism is an official RFC. |
OAuth Discovery is now RFC 8414, so we don't need to worry about "just a draft" concerns anymore. |
The location of the
.well-known
directory is a bit of a mess..well-known
violates RFC 5785 but is codified in the OIDC standard and in wide use in software implementations.So - what should we do?
The text was updated successfully, but these errors were encountered: