🐛 Fix bug in von
-part name parsing
#423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current system has a name parsing issue around capitalization in comma-style names. This means that
gets parsed as
but BibTeX parses this as
I have modified the parsing code and added relevant test cases drawn from the Tame The BeaST BibTeX reference document.
Style-wise, I found the list manipulation difficult to follow; I added a helper function
rindex
, which makes it easier to understand IMO. This should probably go in a utility file or something, but I didn't see one in the project.I believe these changes will fix at least some of the failing test cases in the name merging PR here: #422