Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix bug in von-part name parsing #423

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Conversation

mlutze
Copy link
Contributor

@mlutze mlutze commented Nov 23, 2023

The current system has a name parsing issue around capitalization in comma-style names. This means that

aa bb, CC

gets parsed as

last: aa bb
first: CC
von: <empty>

but BibTeX parses this as

last: bb
first: CC
von: aa

I have modified the parsing code and added relevant test cases drawn from the Tame The BeaST BibTeX reference document.

Style-wise, I found the list manipulation difficult to follow; I added a helper function rindex, which makes it easier to understand IMO. This should probably go in a utility file or something, but I didn't see one in the project.

I believe these changes will fix at least some of the failing test cases in the name merging PR here: #422

Copy link
Collaborator

@MiWeiss MiWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@MiWeiss MiWeiss changed the title fix name parsing bug 🐛 Fix bug in von-part name parsing Nov 24, 2023
@MiWeiss MiWeiss merged commit d670c18 into sciunto-org:main Nov 24, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants