Declare scmb_wrapped_shell_commands as array #316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes scmbreeze#315 Closes scmbreeze#297 Closes scmbreeze#284
|
I don't have knowledge of how to test this thoroughly. But it works in Thought I'd throw it up for review in case there's nothing else to it |
|
I've made these changes locally. Would be great to merge for the sake of new users. |
|
Seems like this was superseded by #331, and can simply be closed & deleted now? |
|
Excellent! Thanks @jeffbyrnes for the notification, and @ghthor for the other fix :) |
This PR might actually be the correct way to do it. I'm actively working on this |
|
NP! I'll not delete the branch, in case you wanna reopen or anything, all yours |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #315
Closes #297
Closes #284