Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated peer dependency for React 17 #224

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Conversation

ihollander
Copy link
Contributor

Fixes #223

@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.868% when pulling 64597ae on ihollander:master into 3d49010 on scniro:master.

@Sceurpien
Copy link

Seems ok :D

@TAO44123
Copy link

Fixes #223

I try to change the package.json file like you, but no use for me...

@bn185069
Copy link

bn185069 commented Apr 6, 2021

Is anyone able to merge this? This PR has been open since Nov 17 2020

@skystebnicki
Copy link

Yes please, we are also depending on this merge.

@bn185069
Copy link

Hey @mattjared or anyone else available, if it's not too much trouble can you merge this PR for us?

@sachinraja
Copy link

sachinraja commented Apr 28, 2021

If anyone still wants this, just install from @ihollander's fork:
npm install https://github.com/ihollander/react-codemirror2. It's clear this package isn't getting updated anyway. This also fixes #228

@RomanHotsiy
Copy link

Hey @scniro, could you merge this, please? This is a 2 lines PR.

@abdulrahman-khankan
Copy link

@fongandrew @mattjared @drewswaycool could you please merge this PR if you still have write access? Thank you 🙌

@drewswaycool
Copy link
Contributor

@fongandrew @mattjared @drewswaycool could you please merge this PR if you still have write access? Thank you 🙌

I don't, sorry 🤷‍♂️.

@LeifAndersen
Copy link

If anyone cares, I got tired waiting and pushed a version of react-codemirror2 with this patch to npm:

npm install @leifandersen/react-codemirror2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not resolve peer dependency for React 17