Skip to content

Commit

Permalink
fix: remove escaping in the published release message (#464)
Browse files Browse the repository at this point in the history
* fix: remove escaping in the message

* fix: test-release

install version with the release number instead of the channel
  • Loading branch information
scolladon authored Feb 16, 2023
1 parent 571b5c4 commit 9d80ccd
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/on-main-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,19 @@ jobs:
uses: ./.github/actions/install

- name: Publish to npm
run: yarn publish --access public --tag "latest-rc" --new-version $(yarn --silent app:version)
run: yarn publish --access public --tag latest-rc --new-version ${{ needs.prepare-release.outputs.version }}
env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}

test-release:
needs: release
needs: [prepare-release, release]
runs-on: ubuntu-latest
steps:
- name: Install sfdx-cli
run: npm install -g sfdx-cli

- name: Install new plugin version
run: echo y | sfdx plugins:install "sfdx-git-delta@latest-rc"
run: echo y | sfdx plugins:install sfdx-git-delta@${{ needs.prepare-release.outputs.version }}

- name: Test new plugin version
run: sfdx sgd:source:delta --help
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/on-published-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ jobs:
with:
GITHUB_TOKEN: ${{ github.token }}
comment-template: |
Shipped in [release \`{release_tag}\`]({release_link}).
You can install the new version using the version number or the \`latest-rc\` channel
\`\`\`sh
Shipped in [release `{release_tag}`]({release_link}).
You can install the new version using the version number or the `latest-rc` channel
```sh
$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@{release_tag}
\`\`\`
```
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
"homepage": "https://github.com/scolladon/sfdx-git-delta#readme",
"scripts": {
"analysis": "codeclimate analyze",
"app:version": "echo $npm_package_version",
"audit:fix": "npm i --package-lock-only && npm audit fix && rm yarn.lock && yarn import && rm package-lock.json",
"commit": "commit",
"lint": "eslint src/",
Expand Down

0 comments on commit 9d80ccd

Please sign in to comment.