Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: truncated xml values #177

Merged
merged 1 commit into from
Aug 4, 2021
Merged

fix: truncated xml values #177

merged 1 commit into from
Aug 4, 2021

Conversation

scolladon
Copy link
Owner

What does this pull request contains


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes


Configure the xml parser so it does not parse node value and attribute value

Does this close any currently open issues?


closes #175

  • Jest test to check the fix is applied are added.

Any particular element to being able to test locally


Any other comments?


No test have been added because there is no point in testing the vendor lib.

Where has this been tested?


Operating System: Darwin Kernel Version 19.6.0: Tue Jun 22 19:49:55 PDT 2021; root:xnu-6153.141.35~1/RELEASE_X86_64

yarn version: 1.22.11

node version: v14.16.0

git version: 2.32.0

sfdx version: sfdx-cli/7.110.0 darwin-x64 node-v14.16.0

sgd plugin version: 4.7.2

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #177 (35f2ea0) into master (4ab8d15) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #177   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          440       440           
=========================================
  Hits           440       440           
Impacted Files Coverage Δ
src/service/inFileHandler.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab8d15...35f2ea0. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented Aug 2, 2021

Code Climate has analyzed commit 35f2ea0 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon enabled auto-merge (squash) August 2, 2021 16:19
@scolladon scolladon merged commit d0f99b8 into master Aug 4, 2021
@scolladon scolladon deleted the fix/xml-value-truncated branch August 4, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Salesforce:Custom Label: value truncation after diff command
2 participants